[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 2/3] mkfs: Remove unneeded open/close fd test from are_you_sure()



----- Original Message -----
| are_you_sure() function should not make an open/close
| test on the underlying device. The pourpose of this
| function is just to ask a yes/no question to the user.
| If we need a function to do this test, we should create
| a new function with its specific pourpose.
| This patch also fix a call to are_you_sure() function and
| move the are_you_sure() function to the begining of the
| file, allowing it to be used in another part of the code
| 
| Signed-off-by: Carlos Maiolino <cmaiolino redhat com>

Hi,

This all looks good and makes sense.  I am concerned
that removing the open/close might change the behavior
when errors occur: For example, if you try to mkfs.gfs2
for a device you don't have permission to.  Or for a
device that doesn't exist.  Please test those two cases
to make sure nothing weird happens.

Regards,

Bob Peterson
Red Hat File Systems


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]