[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination



----- Original Message -----
| This new method of managing recovery is an alternative to
| the previous approach of using the userland gfs_controld.
| 
| - use dlm slot numbers to assign journal id's
| - use dlm recovery callbacks to initiate journal recovery
| - use a dlm lock to determine the first node to mount fs
| - use a dlm lock to track journals that need recovery
| 
| Signed-off-by: David Teigland <teigland redhat com>
| ---
Hi,

(snip)
| +			if (!test_bit_le(i, lvb_bits+JID_BITMAP_OFFSET))
Nit, but I'd prefer " + " rather than "+" with no spaces.
| +				continue;
| +
| +			__clear_bit_le(i, lvb_bits+JID_BITMAP_OFFSET);
Nit, same.
(snip)
| +				__set_bit_le(i, lvb_bits+JID_BITMAP_OFFSET);
Again, please globally change: s/+/ + / except in instances of "var++".
(snip)

Other than these nits, I have no concerns (other than what Steve pointed out).

Regards,

Bob Peterson
Red Hat File Systems


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]