[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination



On Thu, Jan 05, 2012 at 04:58:22PM +0000, Steven Whitehouse wrote:
> > +	clear_bit(SDF_NOJOURNALID, &sdp->sd_flags);
> > +	smp_mb__after_clear_bit();
> > +	wake_up_bit(&sdp->sd_flags, SDF_NOJOURNALID);
> > +	ls->ls_first = !!test_bit(DFL_FIRST_MOUNT, &ls->ls_recover_flags);
> > +	return 0;
> > +
> 
> This bit of code, which was correct last time you posted this patch
> appears to have reverted to its previous incorrect state. ls_first must

Thanks, I'll move it back, I removed ls_first and put it back in the wrong
place.  I keep forgetting about it because...

> be set before SDF_NOJOURNALID is cleared, otherwise the uninitialised
> value may be read,

in this case there can be no other reader, so it doesn't matter.

Dave


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]