[Cluster-devel] [PATCH 3/3] fsck.gfs2: Fix unchecked malloc in gfs2_dup_set()
Andrew Price
anprice at redhat.com
Fri Jan 20 12:39:27 UTC 2012
Spotted by coverity: Dereferencing a pointer that might be null "data"
when calling "memset"
Signed-off-by: Andrew Price <anprice at redhat.com>
---
gfs2/fsck/util.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/gfs2/fsck/util.c b/gfs2/fsck/util.c
index f37fe7d..6c80ae8 100644
--- a/gfs2/fsck/util.c
+++ b/gfs2/fsck/util.c
@@ -253,6 +253,10 @@ static struct duptree *gfs2_dup_set(uint64_t dblock, int create)
if (!create)
return NULL;
data = malloc(sizeof(struct duptree));
+ if (data == NULL) {
+ log_crit( _("Unable to allocate duptree structure\n"));
+ return NULL;
+ }
dups_found++;
memset(data, 0, sizeof(struct duptree));
/* Add new node and rebalance tree. */
--
1.7.7.5
More information about the Cluster-devel
mailing list