[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 2/2] fsck.gfs2: Fix buffer overflow in get_lockproto_table



----- Original Message -----
| Coverity discovered a buffer overflow in this function where an
| overly
| long cluster name in cluster.conf could cause a crash while repairing
| the superblock. This patch fixes the bug by making sure the lock
| table
| is composed sensibly, limiting the fsname to 16 chars as documented,
| and
| only allowing the cluster name (which doesn't seem to have a
| documented
| max size) to use the remaining space in the locktable name string.
| 
| Signed-off-by: Andrew Price <anprice redhat com>
| ---

Hi,

ACK to both patches.

Regards,

Bob Peterson
Red Hat File Systems


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]