[Cluster-devel] [PATCH] mkfs.gfs2: Follow symlinks before checking device contents

[Bob Peterson]

----- Original Message -----
| +	absname = canonicalize_file_name(sdp->device_name);

Hi Andy,

Thanks for the patch. I just wanted to point out that in the past we've
used realpath rather than canonicalize_file_name. For example, see this patch
we did a long time ago to gfs2_tool:

http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=e70898cfa09939a7100a057433fff3a4ad666bdd

It would be nice if our use was consistent. I'm not sure if there's an
advantage of one over the other. If canonicalize_file_name is now preferred
upstream over realpath, we should probably replace all occurrences of that.

On the other hand, if realpath is now preferred upstream, we should adjust
this patch to use it instead. AFAIK, they are the same, and I don't have a
personal preference; whatever is most favoured by the upstream community. :)

Otherwise, the patch looks good.

Regards,

Bob Peterson
Red Hat File Systems