[Cluster-devel] [PATCH] GFS2: minor readability improvement in gfs2_mount()

Alexey Khoroshilov khoroshilov at ispras.ru
Wed Jun 5 21:29:32 UTC 2013


The patch makes usage pattern of IS_ERR-PTR_ERR more typical.

Signed-off-by: Alexey Khoroshilov <khoroshilov at ispras.ru>
---
 fs/gfs2/ops_fstype.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 0262c19..0d30e8e 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -1313,9 +1313,10 @@ static struct dentry *gfs2_mount(struct file_system_type *fs_type, int flags,
 	}
 	s = sget(fs_type, test_gfs2_super, set_gfs2_super, flags, bdev);
 	mutex_unlock(&bdev->bd_fsfreeze_mutex);
-	error = PTR_ERR(s);
-	if (IS_ERR(s))
+	if (IS_ERR(s)) {
+		error = PTR_ERR(s);
 		goto error_bdev;
+	}
 
 	if (s->s_root)
 		blkdev_put(bdev, mode);
-- 
1.8.1.2




More information about the Cluster-devel mailing list