[Cluster-devel] [PATCH 4/4] mkfs.gfs2: Add align option and update docs

Andrew Price anprice at redhat.com
Thu Jun 6 13:53:42 UTC 2013


On 06/06/13 14:13, Bob Peterson wrote:
> Hi,
>
> ----- Original Message -----
> | +	for (i = 0; options[i] != NULL; i+=2) {
>
> Just a nit here, but I'd recommend adding spaces, as per our standard: "i += 2"

Agreed - thanks.

Andy

>
> | +		printf("%15s  %-22s\n", options[i], options[i+1]);
>
> Same here: "i + 1"
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>




More information about the Cluster-devel mailing list