[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Set log descriptor type for jdata blocks

----- Original Message -----
| > This patch sets the log descriptor type according to whether the
| > journal commit is for (journaled) data or metadata. This was
| > recently broken when the functions to process data and metadata
| > log ops were combined.
| Thanks - looks good. If we can automatically detect the erroneous
| entries, could we also automatically deal with those too? That might be
| useful in case people already have such entries in their logs,
| Steve.


Since the bad entries are data blocks, there's no good way to
distinguish them from other kinds of corrupt metadata. We could
make the code treat them as jdata rather than metadata instead of
throwing the error, but I question whether it's worth it, since the
problem will only present itself upon journal replay, and only on
recent upstream kernels. The problem doesn't exist in RHEL6 or below.
Removing our error checking in favor of treating the blocks as jdata
would make it less effective at finding real metadata block
corruption in the journals, and that seems like a check we should
keep. Still, it's simple enough to do. Opinions?


Bob Peterson
Red Hat File Systems

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]