[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 1/2] fence_ipmilan: port fencing agent to fencing library



On 21/11/13 16:48 +0100, Fabio M. Di Nitto wrote:
> On 11/21/2013 4:16 PM, Ondrej Mular wrote:
>> +PATHS = ["/usr/local/bull/NSMasterHW/bin/ipmitool",
>> +    "/usr/bin/ipmitool",
>> +    "/usr/sbin/ipmitool",
>> +    "/bin/ipmitool",
>> +    "/sbin/ipmitool",
>> +    "/usr/local/bin/ipmitool",
>> +    "/usr/local/sbin/ipmitool"]
> 
> this hard-cording it bad.
> 
> Always use OS define PATH and if really necessary allow user to override
> with an option (for example: --pathtoipmitool=/usr/local....)

see, e.g.,
http://git.engineering.redhat.com/users/jpokorny/clufter/tree/utils.py?id=d37db7470f4e44598af0b91d02221182178677ff#n22
that mimics "which" standard utility

Hope this helps

-- 
Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]