[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 2/3] fence_ipmilan: option --method and new option --ipmitool-path



On 11/29/2013 05:32 PM, Ondrej Mular wrote:

> @@ -147,28 +160,44 @@ def define_new_opts():
>      all_opt["privlvl"] = {
>          "getopt" : "P:",
>          "longopt" : "privlvl",
> -        "help" : "-P, --privlvl=[level]    Privilege level on IPMI device (callback|user|operator|administrator)",
> +        "help" : "-P, --privlvl=[level]          Privilege level on IPMI device (callback|user|operator|administrator)",

All the reformatting and cosmetic changes should be in a separate commit.

Also, this patch assumes that the first patch you posted is applied to
the tree. It's not. Sending incremental patches over patches makes it
difficult to rebuild the final binary and test it (yes I have ipmi
devices at home :))

Fabio


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]