[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [GFS2 PATCH 5/5] GFS2: Do not reset flags on active reservations



Hi,

So I've taken patches 1,2 and 5 from this series. I know that you are
looking into being able to reduce the rbm size by using just the bii and
removing the bitmap pointer, so I'll leave 3 & 4 until thats ready too,
if that makes sense?

Steve.

On Wed, 2013-09-11 at 13:44 -0500, Bob Peterson wrote:
> When we used try locks for rgrps on block allocations, it was important
> to clear the flags field so that we used a blocking hold on the glock.
> Now that we're not doing try locks, clearing flags is unnecessary, and
> a waste of time. In fact, it's probably doing the wrong thing because
> it clears the GL_SKIP bit that was set for the lvb tracking purposes.
> ---
>  fs/gfs2/rgrp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index f023ca6..e4f3362 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -1849,7 +1849,6 @@ int gfs2_inplace_reserve(struct gfs2_inode *ip, u32 requested, u32 aflags)
>  		return -EINVAL;
>  	if (gfs2_rs_active(rs)) {
>  		begin = rs->rs_rbm.rgd;
> -		flags = 0; /* Yoda: Do or do not. There is no try */
>  	} else if (ip->i_rgd && rgrp_contains_block(ip->i_rgd, ip->i_goal)) {
>  		rs->rs_rbm.rgd = begin = ip->i_rgd;
>  	} else {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]