[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] joining the gitfence-agents group



On 03/25/2014 10:56 PM, David Smith wrote:
Hi Marek,

Made the suggestions you've requested and did a quick test, all seems to work.
attached is the new file

Thanks, fence agent is now in upstream, fedora release will follow soon

m,


On Fri, Mar 21, 2014 at 3:50 AM, Marek Grac <mgrac redhat com> wrote:
Hi,


On 03/19/2014 10:26 PM, David Smith wrote:
Hi marek, sure, no problem, here's the changes; also sent to cluster-devel.

thanks, for next time it will be easier to you and other reviewers if you will sent a patch in a standard format. Take a look at
http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html


I've already tested by manually running the fence-raritan agent that this is working and functional

code looks pretty good and after few minor changes it can be accepted.

These are my comments:
    * please remove commented line of source code
    * exception checking 'Due to limitations ...' is not required any more because we have subpackage for every fence-agent so dependencies can be solved properly
    * default value can be now set more easier (--ipport in this case)
        all_opt["ipport"]["default"] = "23"
    * please add support also for delay before login which is very useful for 2-node clusters
        if options["--action"] in ["off", "reboot"]:
                time.sleep(int(options["--delay"]))

m,




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]