[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] fencing: Replace printing to stderr with proper logging solution



On 4/3/2014 10:58 AM, Marek Grac wrote:
> On 04/02/2014 08:14 PM, Fabio M. Di Nitto wrote:
>> On 04/02/2014 05:06 PM, Marek 'marx' Grac wrote:
>>> This patch replaces local solutions by standard python logging 
>>> module. Levels of messages is not final, it just reflects the
>>> previous state. So, debug level is available only with -v /
>>> verbose option.
>> Hi Marek,
>> 
>> are we keeping out-of-tree agents in sync too? specifically
>> fence_virt and fence_sanlock.
> This solution does not change behaviour of fence agents, it is
> more internal thing which is python based so there is no need to
> change anything else.

Right, I understand.

> After we will found out where to add logging and to which levels
> (ERROR, INFO, DEBUG) then it will be good to make other agents work
> in same way.

That´s what I care effectively. Keep it consistent across all agents.

Perhaps we should consider moving fence_sanlock and fence-virt into
fence-agents now that the fence-agents srpm generates many separated
rpm. It will make it easier to keep all features in sync across the board.

Fabio


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]