[Cluster-devel] [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c

Steven Whitehouse swhiteho at redhat.com
Mon Feb 10 12:30:20 UTC 2014


Hi,

On Sun, 2014-02-09 at 18:40 +0530, Rashika Kheria wrote:
> Mark functions as static in gfs2/rgrp.c because they are not used
> outside this file.
> 
> This eliminates the following warning in gfs2/rgrp.c:
> fs/gfs2/rgrp.c:1092:5: warning: no previous prototype for ‘gfs2_rgrp_bh_get’ [-Wmissing-prototypes]
> fs/gfs2/rgrp.c:1157:5: warning: no previous prototype for ‘update_rgrp_lvb’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com>
> Reviewed-by: Josh Triplett <josh at joshtriplett.org>
> ---
>  fs/gfs2/rgrp.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Now in the GFS2 -nmw tree. Thanks,

Steve.

> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index a1da213..551b9e9 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -1102,7 +1102,7 @@ static u32 count_unlinked(struct gfs2_rgrpd *rgd)
>   * Returns: errno
>   */
>  
> -int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
> +static int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
>  {
>  	struct gfs2_sbd *sdp = rgd->rd_sbd;
>  	struct gfs2_glock *gl = rgd->rd_gl;
> @@ -1169,7 +1169,7 @@ fail:
>  	return error;
>  }
>  
> -int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
> +static int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
>  {
>  	u32 rl_flags;
>  





More information about the Cluster-devel mailing list