[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [RFC PATCH 1/5] fs: xstat system call VFS bits



----- Original Message -----
> This patch adds the VFS bits of the xstat patchset by David
> Howells. The xgetdents syscall uses this to obtain stat
> information for directory entries.
> 
> Signed-off-by: Abhi Das <adas redhat com>
> ---
>  arch/x86/syscalls/syscall_32.tbl |   2 +
>  arch/x86/syscalls/syscall_64.tbl |   2 +
>  fs/stat.c                        | 338
>  ++++++++++++++++++++++++++++++++++++---
>  include/linux/fs.h               |   4 +
>  include/linux/stat.h             |  14 +-
>  include/linux/syscalls.h         |   5 +
>  include/uapi/linux/fcntl.h       |   1 +
>  include/uapi/linux/stat.h        | 110 +++++++++++++
>  8 files changed, 453 insertions(+), 23 deletions(-)
(snip)
> +static int xstat_get_params(unsigned int mask, struct xstat __user *buffer,
> +			    struct kstat *stat)
> +{
> +	memset(stat, 0xde, sizeof(*stat)); // DEBUGGING

Did you forget to remove this DEBUGGING statement? In either case, the c++
comment should be /* */.

Regards,

Bob Peterson
Red Hat File Systems


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]