[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] GFS2: return -E2BIG if hit the maximum limits of ACLs



Hi,

Now in the -nmw tree. Thanks,

Steve.

On Tue, 2014-03-04 at 11:28 +0800, Jeff Liu wrote:
> From: Jie Liu <jeff liu oracle com>
> 
> Return -E2BIG rather than -EINVAL if hit the maximum size limits of
> ACLs, as the former errno is consistent with VFS xattr syscalls.
> 
> This is pointed out by Dave Chinner in previous discussion thread:
> http://www.spinics.net/lists/linux-fsdevel/msg71125.html
> 
> Signed-off-by: Jie Liu <jeff liu oracle com>
> ---
>  fs/gfs2/acl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
> index ba94566..9c59ebe 100644
> --- a/fs/gfs2/acl.c
> +++ b/fs/gfs2/acl.c
> @@ -86,7 +86,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type)
>  	BUG_ON(name == NULL);
>  
>  	if (acl->a_count > GFS2_ACL_MAX_ENTRIES)
> -		return -EINVAL;
> +		return -E2BIG;
>  
>  	if (type == ACL_TYPE_ACCESS) {
>  		umode_t mode = inode->i_mode;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]