[Cluster-devel] [GFS2 PATCH 1/2][TRY #2] GFS2: Move glock superblock pointer to field gl_name

Bob Peterson rpeterso at redhat.com
Wed Aug 26 14:12:20 UTC 2015


----- Original Message -----
> Bob,
> 
> how hard would it be to move the rhashtable into struct gfs2_sbd instead?
> 
> Thanks,
> Andreas

Hi Andreas,

I've suggested moving the glock hash table into the superblock a couple times
in the past, when it was still a normal hash table, but I've always been shot
down. The advantage was improved scalability and not having to filter out
the glocks you don't want from the ones you don't when you go to do things
like dumping glocks. There's one central point for all glocks everywhere.
With rhashtable, scalability isn't much of an issue anymore. The disadvantage
is having multiple hash tables to manage when you are trying to clear things
out when you're unloading the module, for example. I've always felt the
advantages outweighed the disadvantages, but others did not agree.

Regards,

Bob Peterson
Red Hat File Systems




More information about the Cluster-devel mailing list