[Crash-utility] Re: [PATCH] IA-64 4-level page table support

[Dave Anderson]

> Attached is a patch that adds 4-level page table support to the IA-64
> architecture. I followed the way PPC used the machdep command line
> argument to force it. Since this is truly a CONFIG option on IA-64, I
> have also added a routine to parse the required information out of
> IKCONFIG if it's available. I'm thinking about requiring IKCONFIG for
> LKCD, because it just makes life easer.
>
> As a side note, I decided I hate how everything is piled into defs.h
> and separated by ifdefs. Dave, how do you feel about breaking defs.h
> up into a header for each arch, i.e. ia64_defs.h, ppc_def.h, etc, and
> a small common defs.h?
>
> Thanks,
>
> Troy
>

Hi Troy,

Nice work...

The only issues I see is that the read_config() and read_config_err()
should probably go into a common file in case we ever need them for
other configuration-related stuff in the future, and couple of the malloc()
error messages in read_config() are cut-and-pasted and refer to
"ia64_memmap".

I'll give it a run against a 3 leveler to make sure nothing breaks.

As far as the defs.h split-up, I have no argument against doing that.

Thanks,
   Dave



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20060801/b7bd2c28/attachment.htm>