[Crash-utility] Re: typo affects kmem -S error output

Dave Anderson anderson at redhat.com
Tue Dec 4 21:46:54 UTC 2007


Bob Montgomery wrote:
> Dave,
> 
> This patch fixes a typo in memory.c.
> 
> Before:
> =======
> crash> kmem -S sctp_bind_bucket
> ...
> kmem: "sctp_bind_bucket" cache: object 0 on both free and cpu 651223584
> lists
> ...
> 
> (Note cpu number)
> 
> After:
> ====== 
> crash> kmem -S sctp_bind_bucket
> ...
> kmem: "sctp_bind_bucket" cache: object ffff810126d0e220 on both free and
> cpu 0 lists
> ...
> 
> Bob Montgomery
> Working at HP in Fort Collins
> 
> 
> ------------------------------------------------------------------------
> 
> --- memory.c.orig	2007-12-04 14:10:22.000000000 -0700
> +++ memory.c	2007-12-04 14:10:46.000000000 -0700
> @@ -9653,7 +9653,7 @@ dump_slab_objects_percpu(struct meminfo 
>  		if (on_free_list && on_cpudata_list) {
>  			error(INFO, 
>  		    "\"%s\" cache: object %lx on both free and cpu %d lists\n",
> -				si->curname, si->cpu, obj);
> +				si->curname, obj, si->cpu);
>  			si->errors++;
>  		}
>  		if (on_free_list && on_shared_list) {

Thanks Bob -- queued for the next release.

Dave





More information about the Crash-utility mailing list