[Crash-utility] [PATCH] Fix compile warnings

Bernhard Walle bwalle at suse.de
Wed Jan 17 09:54:44 UTC 2007


Hello,

patch attached. Please consider to add the changes mainline. But
please also check back all changes.

Some comments:

  gdb/dwarf2-frame.c:
    - I think the buf += overwrites the ++, at least my tests with
      some test codes showed that.
  
  tools.c:
    - this is really strange, if index = 0, then the assignment
      doesn't make sense. If it's random, it also doesn't make sense.  :)
      Didn't have time to dig into the whole logic of this hashtable.


Regards,
 Bernhard

-------------- next part --------------
A non-text attachment was scrubbed...
Name: crash-fix-gcc-warnings.diff
Type: text/x-patch
Size: 2549 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20070117/d1e1f21c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20070117/d1e1f21c/attachment.sig>


More information about the Crash-utility mailing list