[Crash-utility] [PATCH] Fix compile warnings

[Bernhard Walle]

Hello,

* Dave Anderson <anderson at redhat.com> [2007-01-18 15:22]:
> Ok then, I trust your "equivalency" explanation, and since in all
> probability the code path won't be hit, it should be safe.
> In fact, I don't believe that any of the other patches that you
> sent will ever be exercised by crash either?

I didn't check it. I just fixed compiler warnings.

> But, if they make your compiler happy, that's fine with me...

It's your compiler, too. :) Yes, maybe you use another $RPM_OPT_FLAGS
as we do ...

> And given that the gdb module is only utilized as "gdb vmlinux", as
> long as gdb-6.1 is capable of returning structure sizes, member offsets,
> code disassembly, etc., then there's no compelling need to upgrade it.
> And if there are, the first line of defense would be to patch the current
> version than make a wholesale upgrade.

Sounds reasonable.


Regards,
Bernhard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20070118/3ea1c037/attachment.sig>