[Crash-utility] [PATCH] Use /usr/bin/nm -D

[Dave Anderson]

----- "Dave Anderson" <anderson at redhat.com> wrote:

> ----- "Bernhard Walle" <bwalle at suse.de> wrote:
> 
> > * Dave Anderson [2008-08-25 16:07]:
> > >
> > > I'm not sure what's worse -- not doing the translation at all
> > > or showing potentially bogus entries.
> >
> > *arg*, yes, I didn't check for such static functions. The functions
> > in
> > my test were only global, so everything worked.
> >
> > However, I now modified the patch to check the size (with nm -S),
> and
> > report "unknown" in such cases. So we still have the global symbols
> > right, but no "false positives".
> >
> > Is that okay?
> 
> Looks OK -- I'll give it run today, and if no problems arise,
> I'll queue it as is.
> 
> Thanks,
>   Dave

Tests fine, although the "unknown+offset" output is a bit confusing:

  crash> test

  test: invalid structure member offset: task_struct_next_run
        FILE: test.c  LINE: 23  FUNCTION: test_global()

  [/tmp/crash] error trace: 80fd683 => 80fd71b => 80fd5d7 => 813e6ec

    813e6ec: OFFSET_verify+126
    80fd5d7: test_global+51
    80fd71b: unknown+145
    80fd683: cmd_test+137

  test: invalid structure member offset: task_struct_next_run
        FILE: test.c  LINE: 23  FUNCTION: test_global()

  crash>

I'm thinking maybe an "(undetermined)" string would be clearer.

Dave