[Crash-utility] Re: [PATCH] crash: add pcpu_info support

Dave Anderson anderson at redhat.com
Wed Jan 16 16:28:06 UTC 2008


Dave Anderson wrote:
 > Is it necessary that the "pcpu_info" check in get_active_set()
 > needs to come before the "runqueues" and "per_cpu__runqueues"
 > checks?  I'd prefer it to be done last if at all possible.

Never mind -- I see that in your kernel patch you do this:

-       struct task_struct *curr, *idle;
+       struct task_struct *curr;

so the pcpu_info check can be deferred in get_idle_threads()
but not in get_active_set().

Ideally I'd still like to defer it in get_active_set(), but it's
probably not worth the extra effort.

Dave




More information about the Crash-utility mailing list