[Crash-utility] A patch for match_file_string()

Alex Sidorenko asid at hp.com
Fri Mar 14 13:58:41 UTC 2008


On March 14, 2008 09:35:59 am Dave Anderson wrote:
> Anyway, since match_file_string() is used by multiple entities, and in
> the future a caller may actually want to include the linefeed, it doesn't
> seem appropriate to make the change there.
>
> Can you test the attached patch on both a live system and a dumpfile?
> It strips the linefeed from the version string when it's initialized,
> and makes a couple other minor adjustments, including to the first Ubuntu
> patch, which shouldn't be required any more.

Hi Dave,

your patch works fine.  I agree it is safer to strip directly kt->procversion 
as match_file_string() is a general-purpose function and can be eventually 
used for something very different.

Regards,
Alex

-- 
------------------------------------------------------------------
Alexandre Sidorenko             email: alexs at hplinux.canada.hp.com
Global Solutions Engineering:   Unix Networking
Hewlett-Packard (Canada)
------------------------------------------------------------------




More information about the Crash-utility mailing list