[Crash-utility] [PATCH] Fix module size and num_symtab for 2.6.27
Dave Anderson
anderson at redhat.com
Thu Nov 6 18:55:20 UTC 2008
----- "Bernhard Walle" <bwalle at suse.de> wrote:
> This patch implements the kernel change
>
> commit 2f0f2a334bc38b61a9afca951185cd3844ee709d
> Author: Denys Vlasenko <vda.linux at googlemail.com>
> Date: Tue Jul 22 19:24:27 2008 -0500
>
> module: turn longs into ints for module sizes
>
> This shrinks module.o and each *.ko file.
>
> And finally, structure members which hold length of module
> code (four such members there) and count of symbols
> are converted from longs to ints.
>
> We cannot possibly have a module where 32 bits won't
> be enough to hold such counts.
>
> For one, module loading checks module size for sanity
> before loading, so such insanely big module will fail
> that test first.
>
> Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
>
> in crash. Without the patch I was not able to open a core dump created
> with
> 2.6.27 on POWER. I think it's mostly a problem on big endian
> architectures,
> because on little endian you can have luck and read zeros which don't
> change
> the value of a number while on big endian you cannot have luck. ;-)
>
>
> Signed-off-by: Bernhard Walle <bwalle at suse.de>
I first thought these might be better served using MEMBER_SIZE(),
but I see that it's most definitely a 2.6.27 (and later) change,
and it's highly unlikely they'll ever go back to the larger sizes.
Queued for the next release.
Thanks,
Dave
More information about the Crash-utility
mailing list