[Crash-utility] Re: [PATCH 3/3] Remove CONFIG_STRICT_DEVMEM

[Bernhard Walle]

* Alan Cox [2008-11-16 15:09]:
>
> > -#ifdef CONFIG_STRICT_DEVMEM
> > -
> >  int devmem_restricted = 1;
> >  
> > -#if defined(CONFIG_SYSCTL) && defined(CONFIG_STRICT_DEVMEM)
> > +#if defined(CONFIG_SYSCTL)
> >  	/*
> >  	 * since there is no unload function, we don't have to deregister that
> >  	 * the whole lifetime of the kernel and can ignore the return value
> 
> NAK - this adds a pile of memory wasting complete crap to every kernel
> including embedded systems. At least before you could turn it off now you
> can't.

For embedded users, do they use CONFIG_SYSCTL at all? If not, then we
can just allow /dev/mem access when CONFIG_SYSCTL is turned on. That
should make embedded users happy.

But: I don't want to get that patch in. I just want to have the sysctl,
if just that patch doesn't make it, well, ok for me. I just think
CONFIG_STRICT_DEVMEM is superfluous when the runtime configuration
option is present.


Regards,
Bernhard