[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Crash-utility] redundant code



----- "Jun Koi" <junkoi2004 gmail com> wrote:

> Hi,
> 
> Function x86_init_kernel_pgd() in x86.c has a redundant code that
> should be removed.
> 

Sure enough -- it got left there when xen came along.
I'll pull it for the next release.

Thanks,
  Dave

> x86_init_kernel_pgd(void)
> {
>     int i;
>     ulong value;
> 
>     value = symbol_value("swapper_pg_dir");  // <--- THIS IS NOT
> NECESSARY
> 
>     if (XEN())
>         get_symbol_data("swapper_pg_dir", sizeof(ulong), &value);
>     else
>         value = symbol_value("swapper_pg_dir");
> 
>     for (i = 0; i < NR_CPUS; i++)
>         vt->kernel_pgd[i] = value;
> }
> 
> 
> Thanks,
> J
> 
> --
> Crash-utility mailing list
> Crash-utility redhat com
> https://www.redhat.com/mailman/listinfo/crash-utility


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]