[Crash-utility] [PATCH] Add support for 'foreign' page sizes in kdump dumps

Dave Anderson anderson at redhat.com
Thu Jan 15 18:21:23 UTC 2009


----- "Bernhard Walle" <bwalle at suse.de> wrote:

> * Dave Anderson [2009-01-14 16:32]:
> > 
> > Now I'm confused -- since the patches to diskdump.c and netdump.c properly set the
> > page size for ia64, why is there any need to change ia64_init()?  If anything,
> > that code could only end up over-writing the pre-determined values returned by
> > diskdump_page_size() and kdump_page_size(), meaning that the diskdump header
> > info or the vmcoreinfo info is in fact invalid?
> 
> For kernels that have no VMCOREINFO. I'll remove that part on your
> request.

Right -- that's true.  And I think that earlier implementation of VMCOREINFO
didn't have the pagesize either.

But let's see how this shakes out for now.

Thanks,
  Dave




More information about the Crash-utility mailing list