[Crash-utility] [PATCH] Add support for 'foreign' page sizes in kdump dumps

[Bernhard Walle]

* Dave Anderson [2009-01-15 13:42]:
>
> @@ -1418,6 +1511,19 @@
>          netdump_print("                 n_type: %lx ", note->n_type);
>         switch (note->n_type)
>         {
> +       case 0: /* unknown, used for VMCOREINFO */
> +
> +               if (strncmp(VMCOREINFO_NOTE_NAME, (char *)note+sizeof(Elf64_Nhdr),
> +                               VMCOREINFO_NOTE_NAME_BYTES) == 0) {
> +
> +                       /* we have VMCOREINFO */
> +                       nd->vmcoreinfo = (char *)nd->elf64 + offset +
> +                               (sizeof(Elf64_Nhdr) + ((note->n_namesz + 3) & ~3));
> +                       nd->size_vmcoreinfo = note->n_descsz;
> +                       nd->page_size = vmcoreinfo_read_integer("PAGESIZE", 0);
> +               }
> +               break;
> +
> 
> So unless you can convince me otherwise, I'll just drop this patch
> segment.

No, you're right. I left that block for code symmetry (but didn't
notice the wrong nd->elf64. In my testing it was not possible to notice
the nd->elf64 since the code block is never executed.

I sent a new patch with this removed.


    Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development

"I have always wished that my computer would be as easy to use as my
telephone. My wish has come true. I no longer know how to use my
telephone." -- Bjarne Stroustrup