[Crash-utility] [PATCH] crash: Fix extend command on s390x

Dave Anderson anderson at redhat.com
Mon Sep 14 14:24:12 UTC 2009


----- "Michael Holzheu" <holzheu at linux.vnet.ibm.com> wrote:

> When loading an extension on s390x, we get the error "xxx.so not an ELF
> format object file". Looks like the problem is a missing check in
> is_shared_object().
> 
> The following patch fixes the problem:
> ---
> diff -Naurp crash-4.0.9/symbols.c
> crash-4.0.9-fix-extend-s390x/symbols.c
> --- crash-4.0.9/symbols.c	2009-09-14 15:47:58.000000000 +0200
> +++ crash-4.0.9-fix-extend-s390x/symbols.c	2009-09-14
> 15:48:04.000000000 +0200
> @@ -2723,6 +2723,10 @@ is_shared_object(char *file)
>  			if (machine_type("X86_64")) 
>  				return TRUE;
>  			break;
> +		case EM_S390:
> +			if (machine_type("S390X"))
> +				return TRUE;
> +			break;
>  		}
>  
>  		if (CRASHDEBUG(1))

Mea culpa.

Queued for the next release.

Thanks,
  Dave




More information about the Crash-utility mailing list