[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Crash-utility] [PATCH] Add ELF core dump support for s390x



On Mon, 2010-02-15 at 17:06 +0100, Michael Holzheu wrote:
> > No major changes other than to rename the machdep->elf_note_add() function
> > to machdep->dumpfile_init().  The idea is that, in the future, if there is
> > ever *anything* in *any* type of dumpfile header that should be transmitted
> > to the architecture code during the dumpfile discovery phase, then that function
> > can be used.  (For example, I could collaborate all of those machdep->xen_xxx()
> > functions into using it, but I'm not going to bother changing them all
> > at this point...)

Sorry, I did not read your note carefully. If you want to do that then
my current implementation is wrong. The problem is that now I expect ELF
note structures and will always do. It is not possible to support
multiple dump formats with my current approach.

My suggestion would be to have one callback per dump format.

Michael


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]