[Crash-utility] [PATCH] Display "irqaction mask" only if available

Dave Anderson anderson at redhat.com
Tue Jan 12 21:42:59 UTC 2010


----- "Bernhard Walle" <bernhard at bwalle.de> wrote:

> Display "irqaction mask" only if available
> 
> The member "mask" has been removed from "struct irqaction" in the
> kernel per
> 
>     commit ef79f8e191722dbc1fc33bdfc448f572266c37e9
>     Author: Rusty Russell <rusty at rustcorp.com.au>
>     Date:   Thu Sep 24 09:34:37 2009 -0600
> 
>     cpumask: remove unused mask field from struct irqaction.
> 
>     Up until 1.1.83, the primitive human tribes used struct sigaction for
>     interrupts.  The sa_mask field was overloaded to hold a pointer to the
>     name.
> 
>     When someone created the new "struct irqaction" they carried across
>     the "mask" field as a kind of ancestor worship: the fact that it was
>     unused makes clear its spiritual significance.
> 
>     Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
> 
> This patch only displays the "irqaction mask" in the "irq" command if the
> member is present.  It fixes the following error (kernel was 2.6.33):
> 
>     crash> irq
> 
>     irq: invalid structure member offset: irqaction_mask
> 	 FILE: kernel.c  LINE: 5001  FUNCTION: generic_dump_irq()
> 
>     [./crash.orig] error trace: 8097e44 => 8109541 => 810c0ec => 8156299
> 
> 
> Signed-off-by: Bernhard Walle <bernhard at bwalle.de>

Thanks Bernhard -- queued for the next release.

Dave




More information about the Crash-utility mailing list