[Crash-utility] [PATCH v2] Remove the VOID_PTR facilitator macro

Dave Anderson anderson at redhat.com
Mon Jan 31 15:51:29 UTC 2011



----- Original Message -----
> I've been wondering about the intended use of this facilitator macro
> for some time and concluded that it is plainly wrong. It should
> take a pointer value from a buffer, but what is the use of a pointer
> that pointed to something on the target machine?
> 
> Since it cannot be meaningfully dereferenced on the host, the only
> (arguable) advantage is the ability to do pointer arithmetics on the
> variables. This second patch does the correct thing wherever pointer
> arithmetics was done, making the actual calculations more explicit.
> 
> Signed-off-by: Petr Tesarik <ptesarik at suse.cz>

The changes to vm_area_dump(), vm_area_page_dump() and next_upage()
have been queued for the next release.

Thanks,
  Dave




More information about the Crash-utility mailing list