[Crash-utility] unwind_arm.c: read_module_unwind_table free(tbl->idx) twice!

[Dave Anderson]

----- Original Message -----
> Hello Dave,
> 
> While I was investigating ARM support for CONFIG_SPARSEMEM, I noticed
> read_module_unwind_table in unwind_arm.c would call free(tbl->idx) twice
> if(!readmem(idx_start, KVADDR, tbl->idx, idx, size,
> "module unwind index table", RETURN_ON_ERROR))
> 
> I think you can remove free(tbl->idx) which just before "return FALSE".
> 
> Takuo

The ARM code is maintained by the Jan and Mika, but you are correct.
I also note that it would do a free(NULL) in the case of a calloc()
failure just above that. 

Thanks, 
  Dave 

> 
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility