[Crash-utility] Accessing integer variables from sial

[Max Matveev]

On Tue, 27 Sep 2011 09:18:03 -0400 (EDT), Dave Anderson wrote:

 DA> ----- Original Message -----
 >> 
 >> Dave, Luc,
 >> 
 >> This is the same patch I've sent to both of you back in January.
 >> It applies cleanly against 5.1.8

 DA> Did you send it directly to us?  (I don't see it in the archives.)

Yeap - it was before I was subscribed to crash-utility.

 DA> BTW, I note that more recent versions of ld make this complaint:

 DA> $ make extensions
 DA> ...

 DA> $ gcc -g -I.. -Ilibsial -I../gdb-7.0/bfd -I../gdb-7.0/include -I../gdb-7.0/gdb -I../gdb-7.0/gdb/config -I../gdb-7.0/gdb/common -I../gdb-7.0 -nostartfiles -shared -rdynamic -o sial.so sial.c -fPIC -DX86_64 -DGDB_7_0 -Llibsial -lsial 
 DA> /usr/bin/ld: Warning: alignment 4 of symbol `sialppdebug' in /tmp/ccYSzE2s.o is smaller than 16 in libsial/libsial.a(sialpp.tab.o)
 DA> /usr/bin/ld: Warning: alignment 4 of symbol `sialdebug' in /tmp/ccYSzE2s.o is smaller than 16 in libsial/libsial.a(sial.tab.o)
 DA> gcc -Wall -I. -nostartfiles -shared -rdynamic -o snap.so snap.c -fPIC -DX86_64 

 DA> By any chance, do you have any insight on how to address that?

Remove explicit initalization for sialppdebug and sialdebug from
sial.c - they're global and will be initialized to 0 anyway. Removing
explict initialization  will push these two into .bss and the warning
goes away, i.e.

--- crash-5.1.8.orig/extensions/sial.c  2011-09-17 05:01:12.000000000 +1000
+++ crash-5.1.8/extensions/sial.c       2011-09-28 15:23:38.393601702 +1000
@@ -737,7 +746,7 @@
 
 
 // these control debug mode when parsing (pre-processor and compile)
-int sialdebug=0, sialppdebug=0;
+int sialdebug, sialppdebug;
 
 void
 load_cmd(void)


But I'll be damned if I can explain why it was generated in the first
place or why does it matter at all.

max