[Crash-utility] [PATCH] s390: Enable live check for --minimal

Michael Holzheu holzheu at linux.vnet.ibm.com
Mon Aug 6 15:51:39 UTC 2012


Hello Dave,

Currently on s390 the check for live dumps is called in s390x_init(POST_INIT).
Unfortunately this code is not executed when the "--minimal" command line
option is specified. Therefore when using this option, "help -p" does not
show the correct information for flags2.

This patch moves the s390x_check_live() invoctation to s390x_init(PRE_GDB),
that is called also for --minimal.

Michael
---
 s390x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/s390x.c
+++ b/s390x.c
@@ -398,6 +398,7 @@ s390x_init(int when)
 		machdep->value_to_symbol = generic_machdep_value_to_symbol;
 		machdep->init_kernel_pgd = NULL;
 		vt->flags |= COMMON_VADDR;
+		s390x_check_live();
 		break;
 
 	case POST_GDB:
@@ -413,7 +414,6 @@ s390x_init(int when)
 		break;
 
 	case POST_INIT:
-		s390x_check_live();
 		break;
 	}
 }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crash-6.0.8-live-check-early.patch
Type: text/x-patch
Size: 851 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20120806/970b3f6a/attachment.bin>


More information about the Crash-utility mailing list