[Crash-utility] [PATCH]: another double free in trace extension

Dave Anderson anderson at redhat.com
Tue Dec 18 20:09:54 UTC 2012


Per,

The fix looks obvious to me.

Qiao or Daisuke, can either of you two please ACK this patch
now that Lai has dropped his support/maintainership of the
trace.c module?

I'd also like to add a "Maintained by: <email-addr>" line to
the trace.c description on the extensions web page.  Should I
put both of you, or just one?

Thanks,
  Dave

----- Original Message -----
> Hi,
> 
> Very similar to the double free I came across earlier this year. No
> need to free cpu_buffer->pages in ftrace_init_pages() since
> ftrace_destroy_buffers() will free it if ftrace_init_pages() returns < 0.
> 
> Regards,
> Per
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility




More information about the Crash-utility mailing list