[Crash-utility] [PATCH] improve the performance of kmem -s [address]

Dave Anderson anderson at redhat.com
Thu Feb 2 18:53:11 UTC 2012



----- Original Message -----
> 
> That all being said, your patch does have merit -- presuming that
> the meminfo.cache field *never* gets set elsewhere prior to entering
> the dump_kmem_cache_xxx functions.  I haven't taken the time to
> verify that -- did you absolutely verify that?

It looks OK to use "if (si->cache)" in those 3 locations -- but it 
would be safer to create/set a unique meminfo->flags bit for this
feature.  

Dave




More information about the Crash-utility mailing list