[Crash-utility] [PATCH v2] add option -s and -S for subcommand irq

Dave Anderson anderson at redhat.com
Tue Jan 17 21:03:02 UTC 2012



----- Original Message -----
> Re-posting two patch as attachments. I'm sorry for the problems on the
> first pass. I have tested the two patches on RHEL 5.8beta (x86, x86_64),
> RHEL 6.2ga (x86, x86_64), and RHEL 6.2ga with kernel 3.2 (x86, x86_64).
> 

I haven't examined the patch, but you've done something 
that has incorrectly changed the behaviour of the simple
"irq" command itself for 2.6.37 and later kernels.

Running crash-6.0.2, here is what the display should look like
for any 2.6.37-and-later kernel -- this example a 3.1.7-1.fc16
kernel:

  crash> irq
   IRQ   IRQ_DESC/_DATA      IRQACTION      NAME
    0   ffff88081ec08400  ffffffff81a11a00  "timer"
    1   ffff88081ec08600      (unused)      
    2   ffff88081ec08800      (unused)      
    3   ffff88081ec08a00      (unused)      
    4   ffff88081ec08c00      (unused)      
    5   ffff88081ec08e00      (unused)      
    6   ffff88081ec09000      (unused)      
    7   ffff88081ec09200      (unused)      
    8   ffff88081ec09400  ffff88080726dc80  "rtc0"
    9   ffff88081ec09600  ffff88080b5a8000  "acpi"
   10   ffff88081ec09800      (unused)      
   11   ffff88081ec09a00      (unused)      
   12   ffff88081ec09c00      (unused)      
   13   ffff88081ec09e00      (unused)      
   14   ffff88081ec0a000      (unused)      
   15   ffff88081ec0a200      (unused)      
   16   ffff88080b7a6800  ffff88080b6a4e80  "megasas"
                          ffff88080b4a6380  "ioc0"
   17   ffff880806c9fe00      (unused)      
   18   ffff880806c9c400      (unused)      
   19   ffff880803a6fe00      (unused)      
   20   ffff880807249c00  ffff880807195c00  "ata_piix"
   21   ffff880807249e00  ffff880807195d80  "ata_piix"
   22   ffff88080724a200  ffff88080726d500  "ehci_hcd:usb1"
                          ffff88080726db80  "ehci_hcd:usb2"
   23       (unused)          (unused)      
   24       (unused)          (unused)      
   25       (unused)          (unused)      
   26       (unused)          (unused)      
   27       (unused)          (unused)      
   28       (unused)          (unused)      
   29       (unused)          (unused)      
   30       (unused)          (unused)      
   31       (unused)          (unused)      
   32       (unused)          (unused)      
   33       (unused)          (unused)      
   34       (unused)          (unused)      
   35       (unused)          (unused)      
   36       (unused)          (unused)      
   37       (unused)          (unused)      
   38       (unused)          (unused)      
   39       (unused)          (unused)      
   40   ffff88080b5c7200  ffff88080b5a8a00  "hpet2"
   41   ffff88080b5c7400  ffff88080b6a4000  "hpet3"
   42   ffff88080b5c7600  ffff88080b6c3080  "hpet4"
   43   ffff88080b5c7800  ffff88080b6e8080  "hpet5"
   44   ffff88080b5c7a00  ffff88080b46a780  "hpet6"
   45   ffff88080a649e00  ffff88080a431c00  "PCIe PME"
   46   ffff88080a64a000  ffff88080a431c80  "PCIe PME"
   47   ffff88080a64a200  ffff88080a431d00  "PCIe PME"
   48   ffff88080a64a400  ffff88080a431d80  "PCIe PME"
   49   ffff88080a64a600  ffff88080a431e00  "PCIe PME"
   50   ffff88080a64a800  ffff88080a431e80  "PCIe PME"
   51   ffff880803993600  ffff880804643000  "p4p1"
   52   ffff880803a6f200  ffff880804643480  "p5p1-rx-0"
   53   ffff880802316c00  ffff880804643400  "p5p1-tx-0"
   54   ffff880802314800  ffff880804643100  "p5p1"
   55   ffff880804653a00  ffff8807feb1c200  "em1-0"
   56   ffff880804653800  ffff8808002d7680  "em1-1"
   57   ffff880804652a00  ffff8808002d7500  "em1-2"
   58   ffff880804652e00  ffff8808002d7a00  "em1-3"
   59   ffff880804652c00  ffff8808002d7b80  "em1-4"
   60   ffff880804652000  ffff8808002d7400  "em1-5"
   61   ffff880804652400  ffff8808002d7580  "em1-6"
   62   ffff880804653600  ffff8808002d7380  "em1-7"
   63   ffff880804653e00      (unused)      
   64   ffff880806ff2a00  ffff880800302600  "em2-0"
   65   ffff880806ff2400  ffff880800302880  "em2-1"
   66   ffff8807fdae7c00  ffff880800302f00  "em2-2"
   67   ffff8807fdae7e00  ffff880800302900  "em2-3"
   68   ffff8807fdae4200  ffff880800302000  "em2-4"
   69   ffff8807fbf36a00  ffff880800302380  "em2-5"
   70   ffff8807fbf36200  ffff880800302b80  "em2-6"
   71   ffff880800237e00  ffff880800302e00  "em2-7"
   72   ffff880800237c00      (unused)      
   73   ffff880803990200  ffff880804643180  "p3p1-0"
   74   ffff880803990a00  ffff880804643800  "p3p1-1"
   75   ffff880803990400  ffff880804643780  "p3p1-2"
   76   ffff880803990c00  ffff880804643700  "p3p1-3"
   77   ffff880803990600  ffff880804643d80  "p3p1-4"
   78   ffff880803993200  ffff88080b7d9900  "p3p2-0"
   79   ffff880803993400  ffff88080b7d9400  "p3p2-1"
   80   ffff880803992c00  ffff88080b7d9300  "p3p2-2"
   81   ffff880803992000  ffff88080b7d9a00  "p3p2-3"
   82   ffff880803993000  ffff88080b7d9700  "p3p2-4"
   83       (unused)          (unused)      
   84       (unused)          (unused)      
   85       (unused)          (unused)      
   86       (unused)          (unused)      
   ... [ cut ] ...
   931      (unused)          (unused)      
   932      (unused)          (unused)      
   933      (unused)          (unused)      
   934      (unused)          (unused)      
   935      (unused)          (unused)      
  crash> 

With your patch applied, it seems to be displaying the
unused IRQ's the "old" way that it is done for pre-2.6.37 
kernels:
  
  crash> irq
   IRQ   IRQ_DESC/_DATA      IRQACTION      NAME
    0   ffff88081ec08400  ffffffff81a11a00  "timer"
    1   ffff88081ec08600      (unused)      
    2   ffff88081ec08800      (unused)      
    3   ffff88081ec08a00      (unused)      
    4   ffff88081ec08c00      (unused)      
    5   ffff88081ec08e00      (unused)      
    6   ffff88081ec09000      (unused)      
    7   ffff88081ec09200      (unused)      
    8   ffff88081ec09400  ffff88080726dc80  "rtc0"
    9   ffff88081ec09600  ffff88080b5a8000  "acpi"
   10   ffff88081ec09800      (unused)      
   11   ffff88081ec09a00      (unused)      
   12   ffff88081ec09c00      (unused)      
   13   ffff88081ec09e00      (unused)      
   14   ffff88081ec0a000      (unused)      
   15   ffff88081ec0a200      (unused)      
   16   ffff88080b7a6800  ffff88080b6a4e80  "megasas"
                          ffff88080b4a6380  "ioc0"
   17   ffff880806c9fe00      (unused)      
   18   ffff880806c9c400      (unused)      
   19   ffff880803a6fe00      (unused)      
   20   ffff880807249c00  ffff880807195c00  "ata_piix"
   21   ffff880807249e00  ffff880807195d80  "ata_piix"
   22   ffff88080724a200  ffff88080726d500  "ehci_hcd:usb1"
                          ffff88080726db80  "ehci_hcd:usb2"
      IRQ: 23 (unused)
  
      IRQ: 24 (unused)
  
      IRQ: 25 (unused)
  
      IRQ: 26 (unused)
  
      IRQ: 27 (unused)
  
      IRQ: 28 (unused)
  
      IRQ: 29 (unused)
  
      IRQ: 30 (unused)
  
      IRQ: 31 (unused)
  
      IRQ: 32 (unused)
  
      IRQ: 33 (unused)
  
      IRQ: 34 (unused)
  
      IRQ: 35 (unused)
  
      IRQ: 36 (unused)
  
      IRQ: 37 (unused)
  
      IRQ: 38 (unused)
  
      IRQ: 39 (unused)
  
   40   ffff88080b5c7200  ffff88080b5a8a00  "hpet2"
   41   ffff88080b5c7400  ffff88080b6a4000  "hpet3"
   42   ffff88080b5c7600  ffff88080b6c3080  "hpet4"
   43   ffff88080b5c7800  ffff88080b6e8080  "hpet5"
   44   ffff88080b5c7a00  ffff88080b46a780  "hpet6"
   45   ffff88080a649e00  ffff88080a431c00  "PCIe PME"
   46   ffff88080a64a000  ffff88080a431c80  "PCIe PME"
   47   ffff88080a64a200  ffff88080a431d00  "PCIe PME"
   48   ffff88080a64a400  ffff88080a431d80  "PCIe PME"
   49   ffff88080a64a600  ffff88080a431e00  "PCIe PME"
   50   ffff88080a64a800  ffff88080a431e80  "PCIe PME"
   51   ffff880803993600  ffff880804643000  "p4p1"
   52   ffff880803a6f200  ffff880804643480  "p5p1-rx-0"
   53   ffff880802316c00  ffff880804643400  "p5p1-tx-0"
   54   ffff880802314800  ffff880804643100  "p5p1"
   55   ffff880804653a00  ffff8807feb1c200  "em1-0"
   56   ffff880804653800  ffff8808002d7680  "em1-1"
   57   ffff880804652a00  ffff8808002d7500  "em1-2"
   58   ffff880804652e00  ffff8808002d7a00  "em1-3"
   59   ffff880804652c00  ffff8808002d7b80  "em1-4"
   60   ffff880804652000  ffff8808002d7400  "em1-5"
   61   ffff880804652400  ffff8808002d7580  "em1-6"
   62   ffff880804653600  ffff8808002d7380  "em1-7"
   63   ffff880804653e00      (unused)      
   64   ffff880806ff2a00  ffff880800302600  "em2-0"
   65   ffff880806ff2400  ffff880800302880  "em2-1"
   66   ffff8807fdae7c00  ffff880800302f00  "em2-2"
   67   ffff8807fdae7e00  ffff880800302900  "em2-3"
   68   ffff8807fdae4200  ffff880800302000  "em2-4"
   69   ffff8807fbf36a00  ffff880800302380  "em2-5"
   70   ffff8807fbf36200  ffff880800302b80  "em2-6"
   71   ffff880800237e00  ffff880800302e00  "em2-7"
   72   ffff880800237c00      (unused)      
   73   ffff880803990200  ffff880804643180  "p3p1-0"
   74   ffff880803990a00  ffff880804643800  "p3p1-1"
   75   ffff880803990400  ffff880804643780  "p3p1-2"
   76   ffff880803990c00  ffff880804643700  "p3p1-3"
   77   ffff880803990600  ffff880804643d80  "p3p1-4"
   78   ffff880803993200  ffff88080b7d9900  "p3p2-0"
   79   ffff880803993400  ffff88080b7d9400  "p3p2-1"
   80   ffff880803992c00  ffff88080b7d9300  "p3p2-2"
   81   ffff880803992000  ffff88080b7d9a00  "p3p2-3"
   82   ffff880803993000  ffff88080b7d9700  "p3p2-4"
      IRQ: 83 (unused)
  
      IRQ: 84 (unused)
  
      IRQ: 85 (unused)
  
      IRQ: 86 (unused)
  
   ... [ cut ] ...
  
      IRQ: 931 (unused)
  
      IRQ: 932 (unused)
  
      IRQ: 933 (unused)
  
      IRQ: 934 (unused)
  
      IRQ: 935 (unused)
  
Dave




More information about the Crash-utility mailing list