[Crash-utility] [ANNOUNCE] crash gcore command, version 1.1 available

[Lei Wen]

Hi HATAYAMA,

> -----Original Message-----
> From: HATAYAMA Daisuke [mailto:d.hatayama at jp.fujitsu.com]
> Sent: Friday, March 23, 2012 8:38 AM
> To: crash-utility at redhat.com; Lei Wen
> Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
> available
> 
> From: Dave Anderson <anderson at redhat.com>
> Subject: Re: [Crash-utility] [ANNOUNCE] crash gcore command, version 1.1
> available
> Date: Thu, 22 Mar 2012 11:23:36 -0400 (EDT)
> 
> > Can you please format the crash-gcore-command-1.1.tar.gz file in
> > the same manner as crash-gcore-command-1.0.tar.gz?  Here is the
> > current version:
> 
> Thanks for pointing out that, Dave. I attached new one.
> 
> And for Lei, I made bigger fault that I missed arm source
> file... Could you confirm that the new one can work on arm
> environment?

Yes, this version works for me.

However, I think there is a point may need to be enhanced:
diff --git a/extensions/libgcore/gcore_coredump.c b/extensions/libgcore/gcore_coredump.c
index e2d9941..fec8ffc 100644
--- a/extensions/libgcore/gcore_coredump.c
+++ b/extensions/libgcore/gcore_coredump.c
@@ -200,7 +200,8 @@ void gcore_coredump(void)
                                        "readmem vma list",
                                        gcore_verbose_error_handle());
                        } else {
-                               pagefaultf("page fault at %lx\n", addr);
+                               if (paddr == PADDR_NOT_AVAILABLE)
+                                       pagefaultf("page fault at %lx\n", addr);
                                BZERO(buffer, PAGE_SIZE);
                        }

Without this, I would see many " page fault at XXX" for the lazy mapping as we talked in the previous thread:
http://www.redhat.com/archives/crash-utility/2012-February/msg00112.html


> 
> Thanks.
> HATAYAMA, Daisuke

Thanks,
Lei