[Crash-utility] ARM: gcore, arm_regsets causes segfault

[HATAYAMA Daisuke]

From: Lei Wen <adrian.wenl at gmail.com>
Subject: Re: [Crash-utility] ARM: gcore, arm_regsets causes segfault
Date: Sun, 13 May 2012 23:06:10 +0800

> Hi HATAYAMA,
> 
> On Thu, May 10, 2012 at 8:24 AM, HATAYAMA Daisuke
> <d.hatayama at jp.fujitsu.com> wrote:
>> From: Per Fransson <per.fransson.ml at gmail.com>
>> Subject: [Crash-utility] ARM: gcore, arm_regsets causes segfault
>> Date: Wed, 9 May 2012 18:01:56 +0200
>>
>>> Hi,
>>>
>>> The for loop in
>>>
>>>    libgcore/gcore_coredump.c:fill_thread_core_info()
>>>
>>> does a
>>>
>>>    notesize(struct memelfnote *)
>>>
>>> where memelfnote->name points to the name of the corresponding
>>> arm_regset member (except REGSET_GPR).
>>>
>>> But notesize calls strlen on those strings and
>>>
>>>    arm_regsets[REGSET_VFP]->name == 0x0
>>>
>>> making it segfault.
>>>
>>> Regards,
>>> Per
>>>
>>
>> Hello Fransson,
>>
>> Thanks for your report.
>>
>> Lei, could you review and test attached patch?
> 
> 
> I'm ok with this patch, and it pass my local test.
> 
> Thanks,
> Lei
> 

Thanks, Lei. I'll post fixed version soon.

Thanks.
HATAYAMA, Daisuke