[Crash-utility] [PATCH v3 00/21] support hiding data of offline cpu

Dave Anderson anderson at redhat.com
Mon Oct 6 19:40:12 UTC 2014



Hello Qiao,

I made a few minor documentation changes for the "ps" and "set" help pages,
and for the "crash --help" and crash.8 output.  Aside from that, your v3 patchset
has been queued for crash-7.0.9:

 https://github.com/crash-utility/crash/commit/d5b362edf7d529a38acbd6dde45696ca29d5daed

Thanks,
  Dave


----- Original Message -----
> For those who don't care about the removed cpu, data of offline cpu is
> bothering. This patchset is trying to hide data of offline cpu. Please
> check each patch to see what is hiden.
> 
> The last version is here:
> https://www.redhat.com/archives/crash-utility/2014-September/msg00078.html
> 
> Changelog:
> v2->v3:
> 1. change "<OFFLINE>" to "[OFFLINE]" to indicate data of offline cpu
> 2. delete the following patches:
>         x86_64: modify help -m/-M to hide offline cpus' data
>         modify help -k to hide offline cpus' number
>         modify irq -a to hide offline cpus' data
>         modify print_task_header() to indicate idle task on offline cpu
> 
> 3. change the following patches to remain the original data and append an
>     "[OFFLINE]" to indicate the data is related to the offline cpu:
>         x86_64: modify mach to hide offline cpus' data
>         modify ptov offset:cpuspec to hide offline cpus' data
>         modify kmem -o to hide offline cpus' data
> 
> 4. change output of "modify display_sys_stats() to hide cpus' number"
> 5. change ps to indicate swapper task on offline cpu with "-"
> 
> v1->v2:
> 1. patch 1: add environment variable and its argument to hide/show
>     data of offline cpu.
> 2. add description of environment variable to crash.8
> 3. remove the restrict of x86_64
> 4. add "<OFFLINE>" to indicate those hiden data.
> 5. patch 22/23: addd "<OFFLINE>" to indicate idle task on offline
> 
> Qiao Nuohan (21):
>    add a flag to display/hide data of offline cpus
>    add an API to check whether to hide a cpus' data
>    x86_64: modify bt -E to hide offline cpus' data
>    x86_64: modify mach to indicate offline cpus' data
>    x86_64: modify mach -c to hide offline cpus' data
>    modify help -r to hide offline cpus' registers
>    modify bt -c to hide offline cpus' data
>    modify display_sys_stats() to indicate offline cpus
>    modify set -c to hide offline cpu
>    modify irq -s to hide offline cpus' data
>    modify timer -r to hide offline cpus' data
>    modify timer to hide offline cpus' data
>    modify ptov offset:cpuspec to indicate offline cpus' data
>    fix max_cpudata_limit() when offlined cpu exists
>    modify kmem -o to indicate offline cpus' data
>    modify kmem -S(SLUB) to hide offline cpus' data
>    modify struct/union/* [:cpuspec] to hide offline cpus' data
>    modify command p to hide offline cpus' data
>    modify ps -l/-m -C cpu to hide offline cpus' data
>    modify runq to hide offline cpus' data
>    modify ps to indicate swapper task on offline cpu
> 
>   crash.8    |  4 ++++
>   defs.h     |  3 +++
>   diskdump.c |  6 ++++-
>   help.c     | 10 +++++++-
>   kernel.c   | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>   main.c     | 15 +++++++++++-
>   memory.c   | 30 ++++++++++++++++++++----
>   netdump.c  | 25 ++++++++++++++++++--
>   symbols.c  | 15 +++++++++++-
>   task.c     | 78
>   +++++++++++++++++++++++++++++++++++++++++++++++++++++---------
>   tools.c    | 15 ++++++++++++
>   x86_64.c   | 46 ++++++++++++++++++++++++++++++------
>   12 files changed, 290 insertions(+), 30 deletions(-)
> 
> --
> 1.8.5.3
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility




More information about the Crash-utility mailing list