[Crash-utility] [PATCH] extensions/trace: Fix ftrace_get_event_type_name()

Minchan Kim minchan at kernel.org
Sun Jul 10 23:50:43 UTC 2016


On Sat, Jul 09, 2016 at 08:21:43PM +0900, Namhyung Kim wrote:
> The recent kernel change dcb0b5575d24 ("tracing: Remove
> TRACE_EVENT_FL_USE_CALL_FILTER logic") changed the bit index so it makes
> checking TRACE_EVENT_FL_TRACEPOINT flag failed.  It should be 0x20 for
> newer kernels.  Without this patch, the crash tool refused to load
> trace.so extension due to invalid access to event names:
> 
>   crash> extend trace.so
>   extend: /path/to/crash/extensions/trace.so: no commands registered: shared object unloaded
> 
> Instead of using the hard-coded value, read the enum value from the
> kernel dynamically.
> 
> Reported-by: Minchan Kim <minchan at kernel.org>
> Cc: Steven Rostedt <rostedt at goodmis.org>
> Signed-off-by: Namhyung Kim <namhyung at gmail.com>

Tested-by: Minchan Kim <minchan at kernel.org>

It works!
Thanks, Namhyung.




More information about the Crash-utility mailing list