[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH][RESEND+fixes] dm + sysfs

On Mon, Dec 08, 2003 at 11:15:20PM -0800, Mike Christie wrote:
> If you look at the attached patch (dm-kobj.patch) built and tested against 
> test10-dm1 you will see kobjects used as a replacement for the "atomic_t 
> holders" value in dm_table and mapped_device. There is no sysfs :)

md_ktype.sysfs_ops ?

> and I did not modify any of the get/put semantics. The only change
> is the kobject infrastructure manages the ref count and calls the
> release function when the count goes to zero.

ok, so your patch does the same as the current code in a slightly more
verbose way ?

> With this patch, I can use the callback method, the sysfs junk will not be 
> coupled to the core code, no abstractions are broken and we will all use 
> the same ref count. Better?

I don't think I really see why you must have the reference counting
done with kobjects rather than the current method.

Remember I'm also maintaining a 2.4 version of dm, and need a really
good reason to have the implementationsh diverge.

- Joe the obtuse.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]