[dm-devel] Re: [RFC] device-mapper ioctl interface

Daniel Phillips dphillips at sistina.com
Mon Jun 9 15:04:01 UTC 2003


On Friday 06 June 2003 19:17, Greg KH wrote:
> On Thu, Jun 05, 2003 at 10:39:43AM +0100, Joe Thornber wrote:
> > Here's the header file for the the proposed new ioctl interface for
> > dm.  We've tried to change as little as possible to minimise code
> > changes in LVM2 and EVMS.
>
> Minor comment:
> 	- please do not use uint_32t types in kernel header files.  Use
> 	  the proper __u32 type which is guarenteed to be the proper
> 	  size across the user/kernel boundry.

We even have a flavor without the __'s:

   http://lxr.linux.no/source/include/asm-i386/types.h?v=2.5.56#L47

A little easier on the eyes, imho.

Regards,

Daniel





More information about the dm-devel mailing list