[lvm-devel] Re: [dm-devel] what to do with fls(x) (or device-mapper & swsusp-1.x.x ? )

[Svetoslav Slavtchev]

> Daniel Phillips wrote:  
>   
> > On Thursday 28 August 2003 16:31, Svetoslav Slavtchev wrote:  
> >   
> >>Hi ,  
> >>i'm tring to incorporate the dev-mapper 1.00.04 in a kernel that already
 
> >>has int fls(int x)  
> >>which conflicts with the definitions in dm-io.[ch]  
> >>(the kernel comes from mandrake cooker and the fls(x) definition is  
> added  
> >>by swsusp patches)  
> >>  
> >>so i wanted to ask you whether the attached patch looks OK,  
> >>it removes the definitions of fls & generic_fls, changes log2_align to  
> use  
> >>fls(int x),  
> >>and adjusts the only referance of  log2_align to use int instead of  
> >>unsigned int.  
> >   
> >   
> > That's fine, except there's no point in changing the unsigned ints to  
> signed   
> > int: unsigned describes more accurately what they are.  The automatic   
> > conversion doesn't generate a warning for you, does it?  
> >   
> the issue is that fls(x) function in 2.6 use int, same as the fls(x) in   
> the swsusp patches, while fls(x) in dm patches use unsigned int.  
> so which would the correct implementation of fls be?  
  
and when i use the dm fls() definition (prefix the fls() definitions with
dm) i can not  
mount a xfs LV without xfs_repair -L,  i get this (shortly, longer ->
attachment 
runed trough ksymoops)  
  
XFS mounting filesystem device-mapper(254,1)  
Starting XFS recovery on filesystem: device-mapper(254,1) (dev: 254/1)  
Filesystem "device-mapper(254,1)": XFS internal error
xlog_valid_rec_header(1)  
at line 3428 of file xfs_log_recover.c.  Caller 0xe0a086af  
da347bac e0a084d2 e0a3b914 00000001 dad9d000 e0a3b6e1 00000d64 e0a086af  
       da607ce0 00000345 00000000 00000001 e0a086af da607ce0 da1bae00  
00000345  
       00000000 da607ce0 00000345 00000000 00000001 dc072980 dc072a40  
00000000  
Call Trace:    [<e0a084d2>] [<e0a3b914>] [<e0a3b6e1>] [<e0a086af>]  
[<e0a086af>]  
  [<e0a08ed7>] [<e0a08f61>] [<e0a09102>] [<e0a3e440>] [<e0a0128c>]  
[<e0a0a684>]  
  [<e0a1d0a9>] [<e0a09c96>] [<e09fedf3>] [<e0a11cfa>] [<e0a252eb>]  
[<e0a24fc1>]  
  [<c0141bcc>] [<e0a40c2c>] [<c014253f>] [<e0a40c2c>] [<c0142867>]  
[<e0a40c2c>]  
  [<c0153c05>] [<c0153ec8>] [<c0153d3d>] [<c01542ba>] [<c0108d63>]  
XFS: log mount/recovery failed  
XFS: log mount failed  
  
this is with:  
device-mapper: 4.0.3-ioctl (2003-08-22) initialised: dm at uk.sistina.com  
 [root at svetljo /]# vgscan --version  
  LVM version:     2.00.06 (2003-08-20)  
  Library version: 1.00.04-ioctl-cvs (2003-08-21)  
  Driver version:  4.0.3  
  
when i use the swsusp fls() there is no such problem  
  
reiserfs doesn't seem to have such issues  
  
best,  
  
svetljo  

-- 
COMPUTERBILD 15/03: Premium-e-mail-Dienste im Test
--------------------------------------------------
1. GMX TopMail - Platz 1 und Testsieger!
2. GMX ProMail - Platz 2 und Preis-Qualitätssieger!
3. Arcor - 4. web.de - 5. T-Online - 6. freenet.de - 7. daybyday - 8. e-Post
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xfs-devmap-prefix-ffs.dmesg-ksymoops
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20030910/58bb0c26/attachment.ksh>