[dm-devel] Re: 2.4 kernel patches: dm-daemon.c & spin_lock_irq

[Brian]

One more addition to the 2.4.21 (and probably 2.4.22 also) patch.  The 
dm-ioctl.h file provided in the patch doesn't include the definition for 
"DM_LIST_VERSIONS", and the library won't compile without it.  I'm surprised 
this hasn't been caught -- I can't believe that anyone could have compiled 
successfully after modifying the kernel with these patches.  Why is 1.00.08 
considered the stable release for 2.4 kernels?

-Brian

--- linux-2.4.21/include/linux/dm-ioctl.h       Mon Apr 5 16:02:20 2004
+++ linux/include/linux/dm-ioctl.h      Tue Apr 6 15:17:12 2004
@@ -185,6 +185,8 @@
         DM_TABLE_CLEAR_CMD,
         DM_TABLE_DEPS_CMD,
         DM_TABLE_STATUS_CMD,
+
+       DM_LIST_VERSIONS_CMD,
  };

  #define DM_IOCTL 0xfd
@@ -192,6 +194,7 @@
  #define DM_VERSION       _IOWR(DM_IOCTL, DM_VERSION_CMD, struct dm_ioctl)
  #define DM_REMOVE_ALL    _IOWR(DM_IOCTL, DM_REMOVE_ALL_CMD, struct dm_ioctl)
  #define DM_LIST_DEVICES  _IOWR(DM_IOCTL, DM_LIST_DEVICES_CMD, struct dm_ioctl)
+#define DM_LIST_VERSIONS _IOWR(DM_IOCTL, DM_LIST_VERSIONS_CMD, struct dm_ioctl)

  #define DM_DEV_CREATE    _IOWR(DM_IOCTL, DM_DEV_CREATE_CMD, struct dm_ioctl)
  #define DM_DEV_REMOVE    _IOWR(DM_IOCTL, DM_DEV_REMOVE_CMD, struct dm_ioctl)