[dm-devel] Re: [PATCH] remove __init from jobs_init in kcopyd.c

Dave Olien dmo at osdl.org
Thu Jun 17 21:05:05 UTC 2004


Sorry about that.  I'm a little behind in my lkml reading

On Thu, Jun 17, 2004 at 10:29:54AM -0500, Kevin Corry wrote:
> Thanks Dave. I actually figured that one out a couple days ago. :) It was 
> already included in the kcopyd patch I sent to akpm on Monday. Check the lkml 
> archives for "[PATCH] DM 1/5: Create/destroy kcopyd on demand".
> 
> On Thursday 17 June 2004 3:18 pm, Dave Olien wrote:
> > kcopyd_init() has been changed from an __init routine to being called
> > kcopyd_client_create().  But the jobs_init() call accidentally remained
> > an __init call. This leads to problems.  This just removes the __init
> > from the jobs_init() declaration.
> >
> > diff -ur linux-2.6.7-rc3-udm1-original/drivers/md/kcopyd.c
> > linux-2.6.7-rc3-udm1-patch1/drivers/md/kcopyd.c ---
> > linux-2.6.7-rc3-udm1-original/drivers/md/kcopyd.c	2004-06-16
> > 10:15:37.000000000 -0700 +++
> > linux-2.6.7-rc3-udm1-patch1/drivers/md/kcopyd.c	2004-06-17
> > 13:08:59.000000000 -0700 @@ -220,7 +220,7 @@
> >  static LIST_HEAD(_io_jobs);
> >  static LIST_HEAD(_pages_jobs);
> >
> > -static int __init jobs_init(void)
> > +static int jobs_init(void)
> >  {
> >  	_job_cache = kmem_cache_create("kcopyd-jobs",
> >  				       sizeof(struct kcopyd_job),
> 
> -- 
> Kevin Corry
> kevcorry at us.ibm.com
> http://evms.sourceforge.net/
> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel



More information about the dm-devel mailing list