[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Re: [dm-devel] kmalloc after down_write?



On Fri, Nov 19, 2004 at 02:16:52PM -0600, Kevin Corry wrote:
> In register_snapshot(), move the kmalloc() outside the _origins_lock. 
 
Maybe - but snapshots and memory allocations don't mix particularly well,
and these are complex trade-offs, so for now I'd rather leave this code 
as it is (i.e. not introduce new allocations), until there's strong 
evidence one way or the other e.g. from testing or more detailed code 
analysis.

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]